mapgen build mesh priority update#1252
Conversation
Updates a small part of Mapgen in order to specify in which Priority you wanna built your meshes. Useful for meshes that uses Transparent Textures, that are drawn over other meshes that use transparency.
Exxample - in mapdef.yml use:
- name: 'Skybox01'
transparentFlag: 1
noShadow: true
uvscIndex: 1
priority: 1
- name: 'Skybox02'
noShadow: true
priority: 2
- name: 'Skybox03'
transparentFlag: 1
noShadow: true
priority: 3
materials with priority 1 will get build first into the kh2.map file.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo files are modified to introduce a material priority system in map generation. A new nullable Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
3 participants
Updates a small part of Mapgen in order to specify in which Priority you wanna built your meshes. Useful for meshes that uses Transparent Textures, that are drawn over other meshes that use transparency.
Exxample - in mapdef.yml use:
basically two small changes. The sort is stable for unprioritized faces (they still preserve their original relative order via "ThenBy(originalIndex)"), and priority 1 will genuinely be the very first mesh built/rendered, priority 2 second, etc.
Hope that's somewhat clear :D
Summary by CodeRabbit